sijie commented on a change in pull request #183: BOOKKEEPER-588 SSL Support
for Bookkeeper
URL: https://github.com/apache/bookkeeper/pull/183#discussion_r124879149
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/AuthHandler.java
##########
@@ -142,11 +145,9 @@ public void channelRead(ChannelHandlerContext ctx, Object
msg) throws Exception
}
private boolean checkAuthPlugin(AuthMessage am, final Channel src) {
- if (!am.hasAuthPluginName()
- ||
!am.getAuthPluginName().equals(authProviderFactory.getPluginName())) {
- LOG.error("Received message from incompatible auth plugin.
Local = {},"
- + " Remote = {}, Channel = {}",
- authProviderFactory.getPluginName(),
am.getAuthPluginName());
+ if (!am.hasAuthPluginName() ||
!am.getAuthPluginName().equals(authProviderFactory.getPluginName())) {
+ LOG.error("Received message from incompatible auth plugin.
Local = {}," + " Remote = {}, Channel = {}",
Review comment:
we don't need '+' if the strings are in the same line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
