sijie commented on a change in pull request #183: BOOKKEEPER-588 SSL Support for Bookkeeper URL: https://github.com/apache/bookkeeper/pull/183#discussion_r124881795
########## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieRequestProcessor.java ########## @@ -79,6 +86,11 @@ */ private final OrderedSafeExecutor writeThreadPool; + /** + * SSL management + */ + private SecurityHandlerFactory shFactory; Review comment: can we make this final? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services