[
https://issues.apache.org/jira/browse/BOOKKEEPER-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15926355#comment-15926355
]
ASF GitHub Bot commented on BOOKKEEPER-1008:
--------------------------------------------
Github user kishorekasi commented on the issue:
https://github.com/apache/bookkeeper/pull/116
Thanks Enrico and Bobby. I will address the comments and update the PR.
Kishore
On Tue, Mar 14, 2017 at 9:42 AM, Robert (Bobby) Evans <
notificati...@github.com> wrote:
> *@revans2* commented on this pull request.
> ------------------------------
>
> In bookkeeper-server/pom.xml
> <https://github.com/apache/bookkeeper/pull/116#discussion_r105961985>:
>
> > @@ -178,8 +208,26 @@
> </exclusion>
> </exclusions>
> </dependency>
> + <dependency>
> + <groupId>io.netty</groupId>
> + <artifactId>netty-all</artifactId>
> + <version>${netty.version}</version>
> + </dependency>
> + <dependency>
> + <groupId>io.netty</groupId>
> + <artifactId>netty-tcnative-boringssl-static</artifactId>
> + <version>${netty-tcnative.version}</version>
> + <classifier>${os.detected.classifier}</classifier>
>
> For me the issue mostly is making sure that we document clearly when a
> release (binary or otherwise) is arch specific, which features depend on
> that arch specific code, and if there is a simple way to work around it
> (like rebuild on the platform you want to run on) how to do that.
>
> Hard coding the architecture to x86_64 does not feel ideal to me.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/bookkeeper/pull/116#discussion_r105961985>, or
mute
> the thread
>
<https://github.com/notifications/unsubscribe-auth/ADKY-ETlsdVkDOMStjkOBvVNdXGMCC_Cks5rlsNngaJpZM4McUUZ>
> .
>
> Move to netty4
> --------------
>
> Key: BOOKKEEPER-1008
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1008
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-client, bookkeeper-server
> Affects Versions: 4.5.0
> Reporter: Robert Joseph Evans
> Assignee: Robert Joseph Evans
>
> As part of the Yahoo push back and in general we would like to move to netty
> 4, preferably netty 4.1.x for the client and server communication.
> This lays the ground work for zero copy, or very nearly zero copy handling on
> the server side.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
