+1 (binding) Downloaded; checked hashes/signatures; checked LICENSE, NOTICE, DISCLAIMER-WIP; compiled and ran tests on Ubuntu, OpenJDK 17, Maven 3.8.1.
Notes 1. I ran RAT and it failed with ’Too many unapproved licenses: 3’. But I don’t agree with the issues it found, one of which was DISCLAIMER-WIP (how ironic). So RAT is ok for now, but please see if you can get RAT to pass next release. 2. A few surprising differences between the tar and git: File in the tar not in git: baremaps-cli/src/test baremaps-ogcapi/target baremaps-server/src/main/resources/maputnik File in git that I would expect to be in the tar: .asf.yaml basemap CODE_OF_CONDUCT.md CONTRIBUTING.md examples .github .gitignore logo.svg README.md RELEASE.md .run scripts (I note that you correctly excluded .git, .mvn, mvnw, mvnw.bat from the tar.) 3. An ‘apache-‘ prefix on the tar file names, and on the directory inside the tars, would be preferable. 4. Version number in README would be nice. 5. I am not an expert, but the NOTICE file possibly includes more projects than necessary. (Remember: Per the AL, any downstream project MUST carry your NOTICE file. So you should only include an upstream project in your NOTICE file if they require it.) 6. The LICENSE file in the -bin.tar should probably have extra entries because you are distributing not just baremaps but all its dependencies. Julian > On Mar 15, 2023, at 8:43 AM, Antoine Drabble <antoine.drab...@gmail.com> > wrote: > > Hi! > > Thank you for all the work on this first release. Here is my vote: > > +1 (unbinding) > > - Builded and tested the src distribution > - Tested the bin distribution on Windows > > Regards, > Antoine Drabble > > > > <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail> > Virus-free.www.avast.com > <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail> > <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2> > > On Tue, 14 Mar 2023 at 21:20, Bertil Chapuis <bchap...@gmail.com> wrote: > >> Hello Everyone, >> >> Let’s give this a second attempt ;) >> >> Please, Do not hesitate to participate and vote even if you're not >> actively involved in the project or if you just subscribed to the mailing >> list. This release process is a great opportunity to engage the community >> and gather valuable feedback. >> >> I have created a build for Apache Baremaps 0.7.1 (incubating), release >> candidate 2. >> >> Thanks to everyone who has contributed to this release and helped >> improving the release process. >> >> You can read the release notes here: >> https://github.com/apache/incubator-baremaps/releases/tag/v0.7.1-rc2 >> >> The commit to be voted upon: >> >> https://github.com/apache/incubator-baremaps/commit/6619632bb56dd20d58280329c5105208c342bfc1 >> >> https://gitbox.apache.org/repos/asf?p=incubator-baremaps.git;a=commit;h=6619632bb56dd20d58280329c5105208c342bfc1 >> >> Its hash is 6619632bb56dd20d58280329c5105208c342bfc1 and its tag >> is v0.7.1-rc2. >> >> The artifacts to be voted on are located here: >> https://dist.apache.org/repos/dist/dev/incubator/baremaps/0.7.1-rc2/ >> >> The hashes of the artifacts are as follows: >> d91dd0f1ebc30a24c7660f6099032eb3b0bc0b36db867dee85e2f8fb6da18113f4b2381fc34a757eb1c0e91522372c66ea75faadc37680cf4c3177ca4eef97a1 >> ./baremaps-0.7.1-incubating-src.tar.gz >> 5023a16b337e75edd58d06b024fb840ad03030885011ab592919aeddc9b1e32fec9969b41037cbb36bb65749e8b05e9da423acac674eba9174ba5001e8fd5074 >> ./baremaps-0.7.1-incubating-bin.tar.gz >> >> Release artifacts are signed with the following key: >> http://people.apache.org/keys/committer/bchapuis.asc >> https://downloads.apache.org/incubator/baremaps/KEYS >> >> The README file for the src distribution contains instructions for >> building and testing the release. >> >> Please vote on releasing this package as Apache Baremaps 0.7.1 >> (incubating). >> The vote is open for the next 72 hours and passes if a majority of at >> least three +1 PMC votes are cast. >> >> [ ] +1 Release this package as Apache Baremaps 0.7.1 (incubating) >> [ ] 0 I don't feel strongly about it, but I'm okay with the release >> [ ] -1 Do not release this package because... >> >> Here is my vote: >> >> +1 (binding) >> >> - Verified the GPG signatures >> - Verified the SHA256 checksums >> - Builded and tested the src distribution >> - Installed the bin distribution >> >> Bertil >> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@baremaps.apache.org For additional commands, e-mail: dev-h...@baremaps.apache.org
