> The merge script would still be useful to flag issues such as a missing component label, or to ensure the fix version (milestone) is set.
It would be possible to turn the current checks for these into a PR check that is obligatory and will block merging until green. [1][2] [1]: https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features#Git.asf.yamlfeatures-Branchprotection [2]: https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/managing-a-branch-protection-rule On Mon, Nov 28, 2022 at 2:40 PM Antoine Pitrou <anto...@python.org> wrote: > > Also a note that discussing this in a thread entitled "Arrow sync call > November 23" might not raise the attention of all interested parties :-) > > > Le 28/11/2022 à 14:38, Antoine Pitrou a écrit : > > > > The merge script would still be useful to flag issues such as a missing > > component label, or to ensure the fix version (milestone) is set. > > > > > > Le 28/11/2022 à 12:09, Joris Van den Bossche a écrit : > >> FYI: Raúl also already opened a PR to update the merge script to work > >> with github issues: https://github.com/apache/arrow/pull/14731 > >> > >> Personally I also think that we should consider using the merge button > >> instead of our script (or at least re-evaluate what the script still > >> does better, or might now we redundant). But so given that the merge > >> script is almost ready to handle github issues, that is a discussion > >> we can have separate from the direct action to start using github > >> issues (it probably needs to wait until the actual JIRA->github > >> migration of the issues has happened, anyway, since until then the > >> script is needed to handle the mix of JIRA and github issues) > >> > >> Joris > >> > >> On Mon, 28 Nov 2022 at 11:44, Andrew Lamb <al...@influxdata.com> wrote: > >>> > >>>> How do apache/arrow-rs, arrow-datafusion, arrow-julia, et al. handle > this? > >>> > >>> arrow-rs and arrow-datafusion use the squash-and-merge button in the > github > >>> UI. > >>> > >>> In general we don't have the same level of curation in commit titles > as the > >>> main arrow repo. However, I have not heard anyone ask for better commit > >>> titles and the github UI / API does a good job tying all commits back > to > >>> the PR they came from. > >>> > >>> Andrew > >>> > >>> On Fri, Nov 25, 2022 at 8:39 PM Neal Richardson < > neal.p.richard...@gmail.com> > >>> wrote: > >>> > >>>>> - This creates an immediate need to modify the PR merge script; Raúl > >>>>> opened an issue for this after the call [6]; this also raises the > >>>>> question of whether we still need the PR merge script or whether > >>>>> committers can use the "Squash and merge" button in the GitHub web UI > >>>>> instead > >>>>> > >>>> > >>>> I think the only thing the merge script will do better than the UI > button > >>>> is that the script always gets the merge commit title correct. IIRC > in the > >>>> GitHub UI, if you merge a PR that has only one commit, it uses the > commit > >>>> message from that commit and not the PR title. Maybe GitHub has fixed > this > >>>> (or let it be configurable). > >>>> > >>>> How do apache/arrow-rs, arrow-datafusion, arrow-julia, et al. handle > this? > >>>> > >>>> Neal > >>>> >
