This is now configurable, but you have to ask Infra to do it. (You can have 
GitHub always use the PR title + description.)

See 
https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/configuring-commit-squashing-for-pull-requests

I assume GitHub also handles multiple Co-authored-by: declarations across 
multiple commits correctly, IIRC the merge script didn't always handle this? so 
it might be worth checking.

-David

On Fri, Nov 25, 2022, at 20:39, Neal Richardson wrote:
>> - This creates an immediate need to modify the PR merge script; Raúl
>> opened an issue for this after the call [6]; this also raises the
>> question of whether we still need the PR merge script or whether
>> committers can use the "Squash and merge" button in the GitHub web UI
>> instead
>>
>
> I think the only thing the merge script will do better than the UI button
> is that the script always gets the merge commit title correct. IIRC in the
> GitHub UI, if you merge a PR that has only one commit, it uses the commit
> message from that commit and not the PR title. Maybe GitHub has fixed this
> (or let it be configurable).
>
> How do apache/arrow-rs, arrow-datafusion, arrow-julia, et al. handle this?
>
> Neal

Reply via email to