FYI: Raúl also already opened a PR to update the merge script to work with github issues: https://github.com/apache/arrow/pull/14731
Personally I also think that we should consider using the merge button instead of our script (or at least re-evaluate what the script still does better, or might now we redundant). But so given that the merge script is almost ready to handle github issues, that is a discussion we can have separate from the direct action to start using github issues (it probably needs to wait until the actual JIRA->github migration of the issues has happened, anyway, since until then the script is needed to handle the mix of JIRA and github issues) Joris On Mon, 28 Nov 2022 at 11:44, Andrew Lamb <al...@influxdata.com> wrote: > > > How do apache/arrow-rs, arrow-datafusion, arrow-julia, et al. handle this? > > arrow-rs and arrow-datafusion use the squash-and-merge button in the github > UI. > > In general we don't have the same level of curation in commit titles as the > main arrow repo. However, I have not heard anyone ask for better commit > titles and the github UI / API does a good job tying all commits back to > the PR they came from. > > Andrew > > On Fri, Nov 25, 2022 at 8:39 PM Neal Richardson <neal.p.richard...@gmail.com> > wrote: > > > > - This creates an immediate need to modify the PR merge script; Raúl > > > opened an issue for this after the call [6]; this also raises the > > > question of whether we still need the PR merge script or whether > > > committers can use the "Squash and merge" button in the GitHub web UI > > > instead > > > > > > > I think the only thing the merge script will do better than the UI button > > is that the script always gets the merge commit title correct. IIRC in the > > GitHub UI, if you merge a PR that has only one commit, it uses the commit > > message from that commit and not the PR title. Maybe GitHub has fixed this > > (or let it be configurable). > > > > How do apache/arrow-rs, arrow-datafusion, arrow-julia, et al. handle this? > > > > Neal > >
