Jeff encouraged me to add more things to this thread, so I’m blaming him. So, some random thoughts.
After getting paid to write code for 20+ years and then showing up at Mozilla, and seeing the a prefix, I thought “this is brilliant, how come we didn’t think of doing that before?!”, as a reasonable balance between nothing and the insanity of the full Hungarian. I find a prefix useful when I’m writing code and when I’m reading it. I have no trouble reading the code that isn’t using this convention. I don’t think I ran into a situation where only some of the arguments in the function were using the prefix (and some were not), but I can imagine that being the only situation where I’d argue that it’s confusing. In other words, as weird as it may sound, I find the prefix improving the readability, but the lack of it not hindering it. And it makes no difference to me when I’m reviewing code, which is a couple of orders of magnitude fewer times than for most people on this thread. If I was writing a new file from scratch, I’d use this convention. If I was in a file that wasn’t using it, it wouldn’t bother me. I think it would be a bad idea to force this consistency on the whole codebase (e.g., either clear it out, or put it everywhere), as I don’t think it would actually solve anything. The “consistent is good” can be taken too far, and I think this would be taking it too far. I honestly think the best thing to do here is nothing - remove it from the style guide if we don’t want to enforce it, but don’t stop me from using it. Blame Jeff for the above. — - Milan On Jul 7, 2015, at 20:41 , Karl Tomlinson <mozn...@karlt.net> wrote: > Jeff Gilbert writes: > >> It can be a burden on the hundreds of devs who have to read and understand >> the code in order to write more code. > > Some people find the prefix helps readability, because it makes > extra information immediately available in the code being > examined, while you are indicating that this is a significant > burden on readability. > > Can you explain why the extra letter is a significant burden? > > If the 'a' prefix is a burden then the 'm' prefix must be also, > and so we should be using this->member instead of mMember. > >> The opinions of a few over-harried >> reviewers should not hold undue sway over the many many devs writing code. > > unless people want code to be reviewed. > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
