Hi, On Sun, 14 Jul 2024 14:44:59 -0400 Boyuan Yang <by...@debian.org> wrote: > Hi, > > 在 2024-07-14星期日的 20:59 +0530，Anoop M S写道：> > On Fri, 31 May 2024 10:48:21 -0400 Boyuan Yang <by...@debian.org> wrote:
> > > Hi, > > > > > > 在 2024-05-31星期五的 08:19 +0000，Anoop M S写道： > > > > Package: wnpp > > > > Severity: wishlist > > > > Owner: Anoop M S <anoo...@disroot.org> > > > > X-Debbugs-Cc: debian-de...@lists.debian.org, anoo...@disroot.org > > > > > > > > * Package name : fcitx5-varnam > > > > Version : 0.0.1 > > > > Upstream Contact: Anoop M S <anoo...@disroot.org> > > > > * URL : https://github.com/varnamproject/varnam-fcitx5 > > > > * License : GPL > > > > Programming Lang: C++ > > > > Description : Fcitx5 wrapper for Varnam input method. > > > > > > > > Fcitx5 wrapper for Varnam(https://www.varnamproject.com) Input > > Method Engine. > > > > Easily type Indian languages on Linux desktops. > > > > > > > > I would like to join Debian Input Method Team, and package and > > maintain it. > > > > And I would need a sponsor to upload it as well. > > >> > > Please prepare an initial version first. You can host it on your own
> > Salsa git repo> > > or via mentors.debian.net , or choose whichever platform that is more
> > convenient to you.> > > Please submit a regular RFS request and notify me once you are prepared.
> > > > > > If it looks good, I can help to move your git packaging repo to the > > Salsa Input Method > > > Team namespace, sponsor the upload and add you into the Salsa Input > > Method Team group. > > > > > > Thanks, > > > Boyuan Yang > > > > I've prepared an initial release and sent RFS (#1076334). > > > > Kindly review at your convenience. > > The following issues are critical and must be fixed: >> * https://github.com/varnamproject/varnam-fcitx5/blob/a2c9412461f68a5293cec24609076951e28a3b27/meson.build#L11-L29 > is unacceptable. The build system is only targeting on x86_64 (amd64) architecture, which is > not reasonable since Debian and Fedora both support multiple hardware architectures.
>> To avoid headaches, I highly recommend switching to CMake buildsystem and reuse
> fcitx5-provided CMake infrastructure. That will make the life easier. If > Meson is the only choice, a more elegant solution is needed. > Will https://mesonbuild.com/CMake-module.html help? >> * Please explain that why you are carrying patches in debian/patches/ directory,
> and why they cannot enter upstream project. >
* That was my mistake, I didn't actually considered other architectures at all. Let me see if its possible to handle it with Meson itself.
If not possible I will switch to CMake.* And regarding those patches, I was trying to create an initial setup without creating a new upstream release. I'll prepare another release once all required changes in upstream is done.
Thank you for your time! Regards, Anoop
OpenPGP_0xDC6CE985B8F95651.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
