Hi,
I think these are close, but there are still a few things to address
before uploading.
1. Autopkgtest command 5 is failing because it can’t access the
plugin assets.
https://salsa.debian.org/ruby-team/redmine/-/jobs/7307022#L14223
This is controlled by:
https://salsa.debian.org/ruby-team/redmine/-/blob/master/debian/tests/
plugin-assets?ref_type=heads
Perhaps we need to update this test file in some way that isn’t
obvious to me to match the new asset directory introduced in 6.0.0.
However, it could also be that there is some problem with the
servicing of the assets that this test is detecting. Either way, I
think we should get it fixed before shipping a release as I don’t want
to break someone’s plugins.
2. Autopkgtest command 6 is failing because the example nginx config
doesn’t appear to be working (probably my attempts to remove FCGI were
incorrect).
https://salsa.debian.org/ruby-team/redmine/-/jobs/7307022#L16930
Can you please see if the example config files are correct for nginx?
https://salsa.debian.org/ruby-team/redmine/-/blob/master/debian/doc/
examples/nginx-alias.conf?ref_type=heads
https://salsa.debian.org/ruby-team/redmine/-/blob/master/debian/doc/
examples/nginx-host.conf?ref_type=heads
Looking through the examples right now it seems clear that all webserver
examples except apache2-passenger used FCGI.
So we will need to provide examples that use another application server
to replace FCGI, e.g. unicorn, and a config for that application server.
Also, is the text environment is being setup correctly:
https://salsa.debian.org/ruby-team/redmine/-/blob/master/debian/tests/
smoke-test-nginx?ref_type=heads
No, it needs a different application server as well.
Because the NEWS entry tells people they need to excise FCGI from
their configs, and points them to these example configs for guidance,
I think it is important we get this fixed before uploading.
Agreed.
Do we need to include code to migrate plugin information from
plugin_assets to assets to match the upstream change in 6.0.0? Does
anything even need to be migrated, or is it all reconfigured during
Rake? Do we need to adjust any of the Redmine plugin packages we
ship? Even if upstream is handling this migration automatically, does
it work with plugins in a multi-tenancy scenario?
Plugins compatible with redmine 6 will work with the multi-tenancy
patches. (we tested https://github.com/happy-se-life/kanban)
lib/redmine/plugin.rb adds the plugins assets directory as an redmine
assets path, so everything regarding the paths is not handled by the
plugins themselves.
The plugin-assets test will not continue to work as all assets are now
served with an added hash in the filename, there is no easy way to check
this anymore.
4. Valentin, remember to add your copyright information to debian/
copyright and to add anything that should be added to debian/
changelog. Thanks for all the work you put into updating the patches.
Thanks for the reminder,
Valentin
