Valentin, On Monday, March 24, 2025 6:36:01 AM Mountain Standard Time Valentin Kleibel wrote: > Hi, > > >>>> 2. Are you able to open a MR on Salsa? If not, I can import > >>>> your > >>>> patches, but it is probably cleaner coming from you. > >>> > >>> Yes. I just registered an account on salsa and waiting for > >>> approval, so it might take a few days until i can do that. > > I created an merge request with the changes: > https://salsa.debian.org/ruby-team/redmine/-/merge_requests/22 > This also includes a small update to bin/redmine-instances to > reflect the recent changes. > > >> Before I upload this, I would just like to make a second call to > >> see if anyone can supply some working lighttpd config examples > >> that don’t depend on FastCGI, support for which was removed in > >> the 6.0.0 release. For context, see: > >> > >> https://lists.debian.org/debian-ruby/2025/02/msg00019.html > > > > Unless Valentin and Adi beat me to it, I might try to find some > > time and look into this but again, let's get redmine fixed, > > uploaded, and migrated first, please. :) > > We run our instances with nginx, so lighthttpd examples are all > yours.
I think these are close, but there are still a few things to address before uploading. 1. Autopkgtest command 5 is failing because it can’t access the plugin assets. https://salsa.debian.org/ruby-team/redmine/-/jobs/7307022#L14223 This is controlled by: https://salsa.debian.org/ruby-team/redmine/-/blob/master/debian/tests/ plugin-assets?ref_type=heads Perhaps we need to update this test file in some way that isn’t obvious to me to match the new asset directory introduced in 6.0.0. However, it could also be that there is some problem with the servicing of the assets that this test is detecting. Either way, I think we should get it fixed before shipping a release as I don’t want to break someone’s plugins. 2. Autopkgtest command 6 is failing because the example nginx config doesn’t appear to be working (probably my attempts to remove FCGI were incorrect). https://salsa.debian.org/ruby-team/redmine/-/jobs/7307022#L16930 Can you please see if the example config files are correct for nginx? https://salsa.debian.org/ruby-team/redmine/-/blob/master/debian/doc/ examples/nginx-alias.conf?ref_type=heads https://salsa.debian.org/ruby-team/redmine/-/blob/master/debian/doc/ examples/nginx-host.conf?ref_type=heads Also, is the text environment is being setup correctly: https://salsa.debian.org/ruby-team/redmine/-/blob/master/debian/tests/ smoke-test-nginx?ref_type=heads Because the NEWS entry tells people they need to excise FCGI from their configs, and points them to these example configs for guidance, I think it is important we get this fixed before uploading. 3. If it isn’t apparent by now, I don’t know much about how the insides of Redmine work. Ruby is not one of the languages I speak (although I might have to pick it up to maintain this package) and I don’t have much experience as a web developer, although I do manage a lot of web services from an IT perspective. All of that is to say that the following questions may expose my ignorance. Do we need to include code to migrate plugin information from plugin_assets to assets to match the upstream change in 6.0.0? Does anything even need to be migrated, or is it all reconfigured during Rake? Do we need to adjust any of the Redmine plugin packages we ship? Even if upstream is handling this migration automatically, does it work with plugins in a multi-tenancy scenario? 4. Valentin, remember to add your copyright information to debian/ copyright and to add anything that should be added to debian/ changelog. Thanks for all the work you put into updating the patches. Once we get these issues addressed I am going to update my sandbox instances and my production instance. Assuming no problems there, we should be ready to upload to unstable. -- Soren Stoutner so...@debian.org
signature.asc
Description: This is a digitally signed message part.
