On Tuesday, March 25, 2025 7:05:32 AM Mountain Standard Time Valentin Kleibel wrote: > Hi, > > > I think these are close, but there are still a few things to > > address before uploading. > > > > 1. Autopkgtest command 5 is failing because it can’t access the > > plugin assets. > > > > https://salsa.debian.org/ruby-team/redmine/-/jobs/7307022#L14223 > > > > This is controlled by: > > > > https://salsa.debian.org/ruby-team/redmine/-/blob/master/debian/te > > sts/ plugin-assets?ref_type=heads > > > > Perhaps we need to update this test file in some way that isn’t > > obvious to me to match the new asset directory introduced in > > 6.0.0. > > However, it could also be that there is some problem with the > > servicing of the assets that this test is detecting. Either way, > > I > > think we should get it fixed before shipping a release as I don’t > > want to break someone’s plugins. > > > > 2. Autopkgtest command 6 is failing because the example nginx > > config doesn’t appear to be working (probably my attempts to > > remove FCGI were incorrect). > > > > https://salsa.debian.org/ruby-team/redmine/-/jobs/7307022#L16930 > > > > Can you please see if the example config files are correct for > > nginx? > > > > https://salsa.debian.org/ruby-team/redmine/-/blob/master/debian/do > > c/ examples/nginx-alias.conf?ref_type=heads > > > > https://salsa.debian.org/ruby-team/redmine/-/blob/master/debian/do > > c/ examples/nginx-host.conf?ref_type=heads > > Looking through the examples right now it seems clear that all > webserver examples except apache2-passenger used FCGI. > So we will need to provide examples that use another application > server to replace FCGI, e.g. unicorn, and a config for that > application server.
That is a good point. When I am done writing this email, I am going to remove the two Apache files that do not use Passenger (all of my testing and production system follow the Apache Passenger example, which is the only way I have ever configured Redmine). > > Also, is the text environment is being setup correctly: > > > > https://salsa.debian.org/ruby-team/redmine/-/blob/master/debian/te > > sts/ smoke-test-nginx?ref_type=heads > > No, it needs a different application server as well. Are you able to provide an example Nginx configuration file and test configuration, using the application server of your choice, that we can 1) recommend to users, especially those switching away from FCGI, and 2) us to test Redmine so we don’t break things accidentally with future updates? I don’t think the Debian package needs to provide examples for every possible configuration, but I think we do need to ship one working Nginx example. I am less concerned about Lighttpd (although I would still like to get a working example if possible), because I think it is less likely that it is being used in a production environment. > > Do we need to include code to migrate plugin information from > > plugin_assets to assets to match the upstream change in 6.0.0? > > Does anything even need to be migrated, or is it all reconfigured > > during Rake? Do we need to adjust any of the Redmine plugin > > packages we ship? Even if upstream is handling this migration > > automatically, does it work with plugins in a multi-tenancy > > scenario? > > Plugins compatible with redmine 6 will work with the multi-tenancy > patches. (we tested https://github.com/happy-se-life/kanban) > lib/redmine/plugin.rb adds the plugins assets directory as an > redmine assets path, so everything regarding the paths is not > handled by the plugins themselves. I have specific concerns about the plugins that Debian ships. https://tracker.debian.org/pkg/redmine-plugin-redhopper https://tracker.debian.org/pkg/redmine-plugin-pretend https://tracker.debian.org/pkg/redmine-plugin-local-avatars https://tracker.debian.org/pkg/redmine-plugin-custom-css > The plugin-assets test will not continue to work as all assets are > now served with an added hash in the filename, there is no easy way > to check this anymore. None of my test setups, nor my production setup, uses plugins. So, I haven’t manually tested any of these before. But, if automatic testing of plugins is no longer possible, I think we need to at least do some manual checks for each of these before a release. I would really like to see Redmine release with trixie, but I am reticent to do so if it breaks users setup more than the required changes in the Apache or Nginx config file to match the 6.0.0 transition. -- Soren Stoutner so...@debian.org
signature.asc
Description: This is a digitally signed message part.
