Hi, Am Tue, Jan 14, 2025 at 07:14:09PM -0800 schrieb Otto Kekäläinen: > > I gave this, specifically reviewing MRs in the debian namespace, a > > try after your last message on this topic. Unfortunately I have to > > say, it feels like a huge waste of time and is mostly frustrating. > > Thanks! Seems we are now down to 838 open MRs in the Debian namespace.
Nice. > > I haven't noted down hard numbers, but my feeling is that 40%+ of the > > MRs are from the janitor-bot, and mostly outdated. Anyone looking at > > the list should immediately filter them out, because they are not > > actionable in any way. > > I would recommend to just skip the janitor ones for now and focus on > providing feedback to humans to facilitate collaboration (among > humans). > > Eventually the person making an upload of a package would be the best > person to merge/reject whatever janitor submitted ones are open. Regarding Janitor: I admit I love these automated tools polishing packages regarding so many issues reported by lintian and beyond. Its really great and I really appreciate what Jelmer did. I use lintian-brush (which is as far as I know the script behind janitor) regularly (= a couple of times per day statistically). A big thank you to Jelmer! However, in all teams I'm deeply involved we asked Jelmer to not run Janitor automatically on the Git repositories. The rationale is, that if a package is not uploaded commits by the Janitor might become outdated - well, finally what is described above is happening. We simply run either lintian-brush (mostly triggered by routine-update which included lintian-brush) right when working / before uploading a package. This makes sure the package is polished *at the right time*. I'm not sure if it is good that Janitor runs on Debian/ team packages if it turns out that people do not care for those MRs created by Janitor. Well, as far as I'm informed Janitor is not creating MRs any more but is commiting directly so the non-human MRs will not be an issue any more (Jelmer, please correct me if I'm wrong). However, if we have somehow structured teams the way Janitor behaves can be written inside the team policy where team members either like those commits or are running the tools manually. For the Debian/ team I'm not really sure what might be the best solution. > I don't know exactly how Salsa is configured regarding notifications. > I agree it should be optimized but don't know exactly how. > > Meanwhile, you can configure your own notification at > https://salsa.debian.org/-/profile/notifications and at least ensure > you are "watching" the pacakges you maintain. Thank you for the reminder. For my taste its suboptimal that users need to actively switch on notifications but I'm aware that we have lots of different tastes and it might make sense to stick to rather less than more notifications default to not bother volunteers with to much information. On the other hand this leads to the observed effect of very many unattended MRs. > > Another is MRs for packages that were removed from unstable a long > > time ago. I've closed them when I encountered them, but did not file > > a ticket to get the repo archived (*). > > Thanks! +1 Regarding archiving the repo: In some teams this is done by moving the repository to some folder named "attic" (or similar). I'm not sure whether removed packages might consume a severe amount of disk space on Salsa. IMHO having the repository around is rather a feature than a bug so I'd tend to keep them even in case of removed packages. > However, I would support the idea of bulk closing MRs and complete > repositories *if* the package has been removed from Debian for the > same reason we bulk close their bug reports. I tend to keep the repository for several reasons: * Users might like to create their own local packages from the last status of the repository. * Vcs fields are published on lots of places and would become broken links for no good reason. * Someone might decided to re-introduce a package and likes to have the history * Repositories might be a great resource for "software-history" What advantages would you see in removing repositories of removed packages except saving some disk space? > > Frustrated, > > Chris Thank you for taking over frustrating work. Its really appreciated. Kind regards Andreas. -- https://fam-tille.de
