Hi, On 2025-01-26 21:08, Holger Wansing wrote: > Hi, > > Aurelien Jarno <aure...@debian.org> wrote (Sun, 26 Jan 2025 18:30:04 +0100): > > > On Sun, 2025-01-26 at 15:00 +0100, Holger Wansing wrote: > > > > Hi, > > > > > > > > Debian FTP Masters <ftpmas...@ftp-master.debian.org> wrote (Tue, 21 Jan > > > > 2025 21:37:53 +0000): > > > > > [ Aurelien Jarno ] > > > > > * Replace legacy timezones with their modern counterparts. Closes: > > > > > #1055541. > > > > > * Update cities/zones that have been renamed. > > > > > * Add templates for Cyprus. > > > > > > > > Tests have shown, that Cyprus as country is only visible, when looking > > > > under > > > > Europe as continent. > > > > Is this correct, since the timezone strings are named "Asia/... " ? > > > > > > > > Asia/Nicosia (most of Cyprus) > > > > Asia/Famagusta (Northern Cyprus) > > > > > > > > > > > > Looks inconsistent to me. > [...] > > > > It seems to be a discrepancy between upstream tzdata which, consider Cyprus > > in Asia, and localechooser, which considers Cyprus in Europe: > > > > https://salsa.debian.org/installer-team/localechooser/-/blob/master/regionmap?ref_type=heads#L167 > > I see. But since we did not receive any complaints in the past about mapping > Cyprus to Europe, that's likely ok. > > The real issue seems to be, that the displayed choices include the continent > as > Asia/Nicosia (most of Cyprus) > Asia/Famagusta (Northern Cyprus) > > This is not the case for any other timezone. It should be > > Nicosia (most of Cyprus) > Famagusta (Northern Cyprus) > > Then the discrepancy from above is no longer an issue (for the user in d-i).
Oh, thanks for the explanations, I understand better your concerns now. You are indeed correct. It seems nobody realized, as it's already like that in bookworm... Maybe we should update gen-templates to not output the continent for automatically generated timezones. > Moreover, this message is lacking the declaration of the sublevel, > that's why the above strings are in sublevel1, while all others from > tzsetup are in sublevel3. Thanks for the details, I wasn't aware of the meaning of that :sl3:. Again we might want to adjust gen-templates to avoid such future mistake if a new timezone is added. > I have attached a patch to fix all the above. Thanks, that looks good. Don't hesitate to tell me if you want me to commit it and do the upload. Regards Aurelien -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurel...@aurel32.net http://aurel32.net
