Vincent Untz (vu...@suse.com) wrote: > What I'm not happy with is the merge process. I think our current > process is broken because it's not able to handle the flow of incoming > pull requests, and when we're trying to compensate this by pushing hard > we do mistakes like this one.
Agreed! The current process is severely lacking in automation. > With the current state of smoketesting (and especially since it doesn't > cover a lot of things, like RHEL/CentOS/SUSE/linuxbridges (and all the > tons of options that can be set)), I feel we shouldn't be blocking on > the smoketesting for merging stuff. Yes, we want to go there, but no, > it's not ready. To me this is all a clear sign that the Crowbar project has outgrown github pull requests, and needs a workflow based on gerrit and Jenkins. github pull requests are fundamentally limited: http://blog.adamspiers.org/2013/05/12/in-partial-defense-of-githubs-review-system/ Until unit tests, smoketests, and any other relevant tests are automatically every time a pull request is created or updated, this misery is guaranteed to continue, and code reliability will be hampered. What's the current state of ./dev ci? It was working at one point, but then got switched off again, IIRC. Of course another limiting factor is that we are still very much divided into OS silos with significantly different build processes. Fixing this has been on the table for between 12-18 months, but I don't think we made much progress yet. These are all complex and mostly unattractive problems to crack, so I can understand why they've been deferred, but I fear maintaining the ostrich approach for much longer is somewhat suicidal ;-) _______________________________________________ Crowbar mailing list Crowbar@dell.com https://lists.us.dell.com/mailman/listinfo/crowbar For more information: http://crowbar.github.com/
