Vincent, This would be a good topic for discussion at the next planning.
I’m reviewing the history on the pulls (which were 4 weeks old) and they had active comment threads. In other cases where community members have expressed reservation, we’ve used a “-1” to indicate a blocking issue to resolve. I agree we should have had two posted +1s (Uncle’s was verbal, not posted) but I think that a -1 flag would have helped prevent this. Rob PS: FWIW, we are NOT currently following this process on CB2 work but will start soon. Victor and I are too closely interlocked/blocked on reviews since we are touching the same code right now. From: crowbar-bounces On Behalf Of Ram, Rajini Sent: Thursday, September 26, 2013 8:28 AM To: Terpstra, John; tsipa...@gmail.com; vu...@suse.com Cc: crowbar; Kanevsky, Arkady Subject: Re: [Crowbar] RHEL/CentOS pull requests merged without any +1 from our side I apologize and will take responsibility too. Will be more diligent. Thanks Rajini From: Terpstra, John Sent: Thursday, September 26, 2013 8:12 AM To: Сергей Юдин; Vincent Untz Cc: crowbar; Kanevsky, Arkady; Ram, Rajini Subject: RE: [Crowbar] RHEL/CentOS pull requests merged without any +1 from our side Vincent/Octavian, Apologies- I gave the OK to merge these patches. I heard that a build with the patches merged passed the smoketests. As an expediency to move forward with clearing the pull-request backlog I asked Rajini to merge them in �C I am sorry, I jumped the gun on these. This was a bad call �C please do not blame Rajini as it was my bad. If it is a serious enough situation feel free to reverse those patches that need to be reworked. - John T. From: Сергей Юдин [mailto:tsipa...@gmail.com] Sent: Thursday, September 26, 2013 6:27 AM To: Vincent Untz Cc: crowbar; Kanevsky, Arkady; Ram, Rajini; Terpstra, John Subject: Re: [Crowbar] RHEL/CentOS pull requests merged without any +1 from our side I'm still subscribed for those PRs and you can adress issues via github - i'm not going to ignore them and i'l fix them if we can find consensus. There was some unnoticed comments, i responded to them. Also sent few style fixes for nova https://github.com/crowbar/barclamp-nova/pull/229 according to yours comments. 2013/9/26 Vincent Untz <vu...@suse.com<mailto:vu...@suse.com>> Hi, The following pull requests got merged while they had no +1 from non-Dell people (and the +1 from Dell happened just before the merge, so with no time for anyone to react), and while there were comments that I feel were either not addressed or needed more discussion: https://github.com/crowbar/barclamp-crowbar/pull/675 https://github.com/crowbar/barclamp-keystone/pull/115 https://github.com/crowbar/barclamp-quantum/pull/118 https://github.com/crowbar/barclamp-nova/pull/221 I explicitly mentioned that some of the RHEL/CentOS pull requests were not ready in the call yesterday, and still this got merged. And of course, now it's unlikely that the comments will ever be addressed... How can we fix that? Vincent -- Les gens heureux ne sont pas pressés. _______________________________________________ Crowbar mailing list Crowbar@dell.com<mailto:Crowbar@dell.com> https://lists.us.dell.com/mailman/listinfo/crowbar For more information: http://crowbar.github.com/
_______________________________________________ Crowbar mailing list Crowbar@dell.com https://lists.us.dell.com/mailman/listinfo/crowbar For more information: http://crowbar.github.com/
