Don't get me wrong, I'm not blaming the people here (and certainly not Sergey who's been taking the feedback and fixing things). The pull requests are probably mostly okay (except for the fact that they increase our technical debt in several ways).
What I'm not happy with is the merge process. I think our current process is broken because it's not able to handle the flow of incoming pull requests, and when we're trying to compensate this by pushing hard we do mistakes like this one. With the current state of smoketesting (and especially since it doesn't cover a lot of things, like RHEL/CentOS/SUSE/linuxbridges (and all the tons of options that can be set)), I feel we shouldn't be blocking on the smoketesting for merging stuff. Yes, we want to go there, but no, it's not ready. Vincent Le jeudi 26 septembre 2013, à 08:11 -0500, john_terps...@dell.com a écrit : > Vincent/Octavian, > > Apologies- I gave the OK to merge these patches. I heard that a build with > the patches merged passed the smoketests. As an expediency to move forward > with clearing the pull-request backlog I asked Rajini to merge them in ?C I > am sorry, I jumped the gun on these. This was a bad call ?C please do not > blame Rajini as it was my bad. If it is a serious enough situation feel free > to reverse those patches that need to be reworked. > > > - John T. > > From: Сергей Юдин [mailto:tsipa...@gmail.com] > Sent: Thursday, September 26, 2013 6:27 AM > To: Vincent Untz > Cc: crowbar; Kanevsky, Arkady; Ram, Rajini; Terpstra, John > Subject: Re: [Crowbar] RHEL/CentOS pull requests merged without any +1 from > our side > > I'm still subscribed for those PRs and you can adress issues via github - i'm > not going to ignore them and i'l fix them if we can find consensus. > > There was some unnoticed comments, i responded to them. Also sent few style > fixes for nova https://github.com/crowbar/barclamp-nova/pull/229 according to > yours comments. > > > 2013/9/26 Vincent Untz <vu...@suse.com<mailto:vu...@suse.com>> > Hi, > > The following pull requests got merged while they had no +1 from > non-Dell people (and the +1 from Dell happened just before the merge, so > with no time for anyone to react), and while there were comments that I > feel were either not addressed or needed more discussion: > > https://github.com/crowbar/barclamp-crowbar/pull/675 > https://github.com/crowbar/barclamp-keystone/pull/115 > https://github.com/crowbar/barclamp-quantum/pull/118 > https://github.com/crowbar/barclamp-nova/pull/221 > > I explicitly mentioned that some of the RHEL/CentOS pull requests were > not ready in the call yesterday, and still this got merged. > > And of course, now it's unlikely that the comments will ever be > addressed... > > How can we fix that? > > Vincent > > -- > Les gens heureux ne sont pas pressés. > > _______________________________________________ > Crowbar mailing list > Crowbar@dell.com<mailto:Crowbar@dell.com> > https://lists.us.dell.com/mailman/listinfo/crowbar > For more information: http://crowbar.github.com/ > > _______________________________________________ > Crowbar mailing list > Crowbar@dell.com > https://lists.us.dell.com/mailman/listinfo/crowbar > For more information: http://crowbar.github.com/ -- Les gens heureux ne sont pas pressés. _______________________________________________ Crowbar mailing list Crowbar@dell.com https://lists.us.dell.com/mailman/listinfo/crowbar For more information: http://crowbar.github.com/