On Wed, 4 Nov 2026 08:37:13 GMT, Volkan Yazici <[email protected]> wrote:

>> Erik Gahlin has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Use -1 to detect EOF
>
> src/java.base/share/classes/java/io/RandomAccessFile.java line 1071:
> 
>> 1069:                 return null;
>> 1070:             }
>> 1071:             return input.toString();
> 
> Nit: Since `diff` is not preserved anyway, you might consider simplifying 
> this:
> 
> 
> return c == -1 && input.isEmpty() ? null : input.toString();

I rather not add simplifications with this bug fix.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33637#discussion_r4466662638

Reply via email to