On Wed, 4 Nov 2026 00:42:03 GMT, Erik Gahlin <[email protected]> wrote:
>> Could I have a review of a PR that fixes a bug in the JFR instrumentation of
>> RandomAccessFile?
>>
>> The problem is that readLine() may produce an event with non-zero number of
>> bytes read and EOF at the same time. To ensure that we get the correct
>> number of bytes, we can't just take the length of the returned String, since
>> readLine() may read one ('\n') or two bytes ('\r\n') for line endings.
>>
>> I added a test that verifies that readLine() returns the same result and
>> leaves the file pointer at the same position with or without JFR enabled.
>>
>> Testing: jdk-tier2 + test/jdk/jdk/jfr
>>
>> Thanks
>> Erik
>>
>>
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Erik Gahlin has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Use -1 to detect EOF
Marked as reviewed by alanb (Reviewer).
src/java.base/share/classes/jdk/internal/event/FileReadEvent.java line 66:
> 64: */
> 65: public static void offer(long start, String path, long bytesRead) {
> 66: if (bytesRead < 0) {
The param description says -1 for EOF but the method treats < 0 as EOF. Not an
issue, just a passing comment.
-------------
PR Review: https://git.openjdk.org/jdk/pull/33637#pullrequestreview-5771469492
PR Review Comment: https://git.openjdk.org/jdk/pull/33637#discussion_r4469879584
