On Thu, 5 Nov 2026 10:30:34 GMT, Erik Gahlin <[email protected]> wrote:
>> Could I have a review of a PR that fixes a bug in the JFR instrumentation of
>> RandomAccessFile?
>>
>> The problem is that readLine() may produce an event with non-zero number of
>> bytes read and EOF at the same time. To ensure that we get the correct
>> number of bytes, we can't just take the length of the returned String, since
>> readLine() may read one ('\n') or two bytes ('\r\n') for line endings.
>>
>> I added a test that verifies that readLine() returns the same result and
>> leaves the file pointer at the same position with or without JFR enabled.
>>
>> Testing: jdk-tier2 + test/jdk/jdk/jfr
>>
>> Thanks
>> Erik
>>
>>
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Erik Gahlin has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Minor fixes
LGTM.
A `@bug` in `@test` block would be nice.
test/micro/org/openjdk/bench/java/io/RandomAccessFileReadLine.java line 84:
> 82: @OperationsPerInvocation(LINES)
> 83: public void readLine(Blackhole bh) throws IOException {
> 84: raf.seek(0);
This is nice. We effectively eliminate the I/O tax and look at the method cost.
-------------
Marked as reviewed by vyazici (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/33637#pullrequestreview-5784603632
PR Review Comment: https://git.openjdk.org/jdk/pull/33637#discussion_r4480163187
