On Tue, 25 Aug 2026 15:51:42 GMT, Fabian Meumertzheim <[email protected]> wrote:

>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Fabian Meumertzheim has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Address comments

test/jdk/java/util/concurrent/forkjoin/GetMultipleWaiters.java line 70:

> 68:             assertInstanceOf(InterruptedException.class, thrown[0]);
> 69:         } finally {
> 70:             task.cancel(false);

If we make the task complete instead of cancelling it, then `task.get()` should 
all return normally and the threads should cleanly exit (making .join() 
succeed).

Suggestion:

            task.complete(null);

test/jdk/java/util/concurrent/forkjoin/GetMultipleWaiters.java line 105:

> 103:         } finally {
> 104:             task.cancel(false);
> 105:             a.join();

`a.join()` is likely not needed here—either it already succeeded, or it was 
Interrupted, in which case it might get interrupted again anyway.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32485#discussion_r3854745556
PR Review Comment: https://git.openjdk.org/jdk/pull/32485#discussion_r3854760904

Reply via email to