On Tue, 25 Aug 2026 15:54:21 GMT, Fabian Meumertzheim <[email protected]> wrote:

>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Fabian Meumertzheim has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Address comments

test/jdk/java/util/concurrent/forkjoin/GetMultipleWaiters.java line 56:

> 54:                 thrown[0] = t;
> 55:             }
> 56:         }, "waiter-A", Thread.State.WAITING);

How about we give all the waiter-threads unique names, "timed-waiter-A" for the 
timed get, and "untimed-waiter-A". That would make it easier to locate any 
issues.

test/jdk/java/util/concurrent/forkjoin/GetMultipleWaiters.java line 71:

> 69:         } finally {
> 70:             task.cancel(false);
> 71:             a.join();

Not needed (see comment on line 105)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32485#discussion_r3854800353
PR Review Comment: https://git.openjdk.org/jdk/pull/32485#discussion_r3854787304

Reply via email to