On Mon, 15 Jun 2026 12:38:15 GMT, Andrew Dinn <[email protected]> wrote:
>>> Should these new stubs be AOT-saved/restored? See how other stubs are doing >>> `load_archive_data` / `save_archive_data` dance. >> >> Yes, thanks. Done. >> >>> A few drive-by comments. I have not dug into the core of the implementation. >>> >>> How would you test this for correctness? >> >> We already have tests. E.g. " >> make test "jtreg:open/test/jdk/sun/security/ec/ECDSAPrimitive.java" >> tests correctness. >> >> @adinn thanks a lot for the thorough review. Unfortunately, from May 26th to >> June 10th I will not be able to work on this, so, please take that into >> consideration with the re-review. > > @ferakocz A few more comments, suggestions and a question. Nearly there. > I think I have addressed every review comment, @adinn, if you are satisfied > with the changes, please approve (and sponsor, please) Have you pushed your most recent changes? Last one I am seeing is from 17 Jun 2026 09:57:05 GMT. ------------- PR Comment: https://git.openjdk.org/jdk/pull/30941#issuecomment-4741773054
