On Fri, 22 May 2026 13:09:56 GMT, Ferenc Rakoczi <[email protected]> wrote:
>> Should these new stubs be AOT-saved/restored? See how other stubs are doing >> `load_archive_data` / `save_archive_data` dance. > >> Should these new stubs be AOT-saved/restored? See how other stubs are doing >> `load_archive_data` / `save_archive_data` dance. > > Yes, thanks. Done. > >> A few drive-by comments. I have not dug into the core of the implementation. >> >> How would you test this for correctness? > > We already have tests. E.g. " > make test "jtreg:open/test/jdk/sun/security/ec/ECDSAPrimitive.java" > tests correctness. > > @adinn thanks a lot for the thorough review. Unfortunately, from May 26th to > June 10th I will not be able to work on this, so, please take that into > consideration with the re-review. @ferakocz A few more comments, suggestions and a question. Nearly there. ------------- PR Comment: https://git.openjdk.org/jdk/pull/30941#issuecomment-4708000134
