On Wed, 20 May 2026 07:52:35 GMT, Aleksey Shipilev <[email protected]> wrote:

>> Ferenc Rakoczi has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Accepting more suggestions from Andrew Dinn.
>
> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 8551:
> 
>> 8549: 
>> 8550:       Label default_loop;
>> 8551:       __ BIND(default_loop);
> 
> How many iterations does this loop do when `length` is `0`? The `sub` below 
> would underflow to `-1`, right? Is it possible to get here with `length == 0`?

I think x86 has an explicit test for `length == 0`:
https://github.com/openjdk/jdk/blob/6fb07f9b26bcd23f622a50c6ca5f23363b432f85/src/hotspot/cpu/x86/stubGenerator_x86_64_poly_mont.cpp#L740-L742

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30941#discussion_r3275327310

Reply via email to