On Fri, 26 Sep 2025 00:51:57 GMT, Alexander Matveev <[email protected]> wrote:
>> - Removed pre- and post- installation PKG scripts. >> - This code is not needed and PKG should create destination folder and set >> correct permissions. >> - If for some reason it is not happens, permissions issues should be fixed >> when jpackage prepares application bundle. PKG should keep all permissions >> unchanged when packaging and installing bundle. >> - Users will have ability to provide pre- and post- installation PKG scripts >> if needed. >> - `INSTALL_LOCATION` and `APP_LOCATION` substitution is removed, since `$1` >> argument in scripts is same as `INSTALL_LOCATION`. >> - I think code in these scripts are some legacy leftovers. >> - Added test to test that pre- and post-scripts are no longer exist and can >> be added via `--resource-dir`. > > Alexander Matveev has updated the pull request with a new target base due to > a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains four additional > commits since the last revision: > > - Merge remote-tracking branch 'upstream/master' into JDK-8356047 > - 8356047: [macos] jpackage produces confusing post- and pre- installation > PKG scripts [v2] > - Merge remote-tracking branch 'upstream/master' into JDK-8356047 > - 8356047: [macos] jpackage produces confusing post- and pre- installation > PKG scripts 8356047: [macos] jpackage produces confusing post- and pre- installation PKG scripts [v3] - Fixed all comments as discussed above. ------------- PR Comment: https://git.openjdk.org/jdk/pull/25510#issuecomment-3341032268
