On Fri, 26 Sep 2025 12:02:08 GMT, Alexey Semenyuk <[email protected]> wrote:
>> Alexander Matveev has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'upstream/master' into JDK-8356047
>> - 8356047: [macos] jpackage produces confusing post- and pre- installation
>> PKG scripts [v2]
>> - Merge remote-tracking branch 'upstream/master' into JDK-8356047
>> - 8356047: [macos] jpackage produces confusing post- and pre- installation
>> PKG scripts
>
> src/jdk.jpackage/share/classes/jdk/jpackage/internal/OverridableResource.java
> line 237:
>
>> 235: Log.verbose(I18N.format("message.no-default-resource",
>> 236: publicName, getPrintableCategory(), publicName));
>> 237: }
>
> Why would we write this log message if there is no consumer for the resource?
If no default resource we will call this function without consumer. I will
remove if statement, since it does not make any difference.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25510#discussion_r2383401187
