On Wed, 28 May 2025 23:09:50 GMT, Alexey Semenyuk <[email protected]> wrote:
>>> Why do we need empty scripts? It doesn't make sense. I'd remove them. >> >> If we do not have empty scripts how user will override it? >> https://docs.oracle.com/en/java/javase/24/jpackage/override-jpackage-resources.html#GUID-62412365-821D-4736-A20D-70F2D47136D8 >> From our documentation we list such files with `--verbose` and placing them >> into Temp folder specified via `--temp`. For scripts we placing them under >> `Temp/scripts`. I am not sure how user will able to figure it out if we do >> not place template files under temp folder. > >> If we do not have empty scripts how user will override it? > > What is the problem with this? By default, PKG will not have scripts. If they > place them in the resource directory, jpackage will use them. @alexeysemenyukoracle Please re-review. Scripts are removed and test is added. ------------- PR Comment: https://git.openjdk.org/jdk/pull/25510#issuecomment-3336407622
