On Wed, 15 Oct 2025 20:14:47 GMT, Johannes Döbler <[email protected]> wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Move fields from package-private to private
>
> src/java.sql/share/classes/java/sql/Statement.java line 1627:
>
>> 1625: */
>> 1626: default String enquoteNCharLiteral(String val) throws SQLException
>> {
>> 1627: return SQLUtils.enquoteNCharLiteral(val);
>
> Suggestion: `return getConnection().enquoteNCharLiteral(val);` to allow JDBC
> driver implementors have a single site to override behavior
No plans to do that in the default implementation. Driver vendors can/should
optimize as needed based on their driver implementation.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27693#discussion_r2433830284
