On Wed, 15 Oct 2025 20:04:45 GMT, Lance Andersen <[email protected]> wrote:
>> This PR adds support for the upcoming JDBC 4.5 MR which provides the
>> following updates to the JDBC specification:
>>
>> - Deprecate SQLPermission for removal
>> - Enhance the Blob/Clob/Array/SQLXML/NClob interfaces to extend/support
>> AutoClosable
>> - Add the SQL types DECFLOAT, JSON to Types.Java and JDBCType.java
>> - Add the quoted identifier methods that **were added previously to the
>> Statement interface in JDK 9** to the Connection interface
>> - It is the exact same verbiage & default methods used when these methods
>> were added to the Statement interface
>> - Clarify the Timestamp::hashCode method which incorrectly indicates that
>> nanos are not used when calculating the hash
>>
>> Tiers 1-3 have been run
>
> Lance Andersen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Move fields from package-private to private
src/java.sql/share/classes/java/sql/Statement.java line 1408:
> 1406: */
> 1407: default String enquoteLiteral(String val) throws SQLException {
> 1408: return SQLUtils.enquoteLiteral(val);
Suggestion: `return getConnection().enquoteLiteral(val);` to allow JDBC driver
implementors have a single site to override behavior
src/java.sql/share/classes/java/sql/Statement.java line 1627:
> 1625: */
> 1626: default String enquoteNCharLiteral(String val) throws SQLException {
> 1627: return SQLUtils.enquoteNCharLiteral(val);
Suggestion: `return getConnection().enquoteNCharLiteral(val);` to allow JDBC
driver implementors have a single site to override behavior
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27693#discussion_r2433814167
PR Review Comment: https://git.openjdk.org/jdk/pull/27693#discussion_r2433815844
