On Fri, 30 May 2025 22:30:25 GMT, Erik Gahlin <egah...@openjdk.org> wrote:

> Could I have review of an enhancement that adds rate-limited sampling to Java 
> event, including five events in the JDK (SocketRead, SocketWrite, FileRead, 
> FileWrite, and JavaExceptionThrow).
> 
> Testing: test/jdk/jdk/jfr
> 
> Thanks
> Erik

src/jdk.jfr/share/classes/jdk/jfr/internal/settings/ThrottlerWindow.java line 
49:

> 47:         measuredPopulationSize.set(0);
> 48:         endTicks = JVM.counterTime() +
> 49:         JVMSupport.nanosToTicks(1_000_000L * 
> parameters.windowDurationMillis);

indent to make it clear it assigns.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25559#discussion_r2119475462

Reply via email to