On Fri, 30 May 2025 22:30:25 GMT, Erik Gahlin <egah...@openjdk.org> wrote:
> Could I have review of an enhancement that adds rate-limited sampling to Java > event, including five events in the JDK (SocketRead, SocketWrite, FileRead, > FileWrite, and JavaExceptionThrow). > > Testing: test/jdk/jdk/jfr > > Thanks > Erik src/jdk.jfr/share/classes/jdk/jfr/internal/EventInstrumentation.java line 257: > 255: getEventConfiguration(codeBuilder); > 256: codeBuilder.aload(0); > 257: getfield(codeBuilder, eventClassDesc, > ImplicitFields.FIELD_START_TIME); In native,we use the endTime for duration events? Is there a need to synchronize the two? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25559#discussion_r2118261907
