On Wed, 4 Jun 2025 14:16:56 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Erik Gahlin has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix adjust boundary
>
> src/jdk.jfr/share/classes/jdk/jfr/Throttle.java line 77:
>
>> 75: * Specifying {@code "off"} (case-sensitive) results in all events
>> being emitted.
>> 76: *
>> 77: * @return the throttle value, default {@code "off"} not {@code null}
>
> I think it would be clearer to drop "not null" from the return description.
We have "not null" with Threshold, but not with "Period". I filed a bug to make
it consistent for all JFR annotations and I can bring Throttle into the same
CSR.
https://bugs.openjdk.org/browse/JDK-8358602
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25559#discussion_r2126946237
