On Wed, 21 May 2025 20:17:45 GMT, Stefan Lobbenmeier <d...@openjdk.org> wrote:
>> src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources.properties
>> line 298:
>>
>>> 296: \ --linux-menu-group <menu-group-name>\n\
>>> 297: \ Menu group this application is placed in\n\
>>> 298: \ --linux-package-deps\n\
>>
>> I am not familiar with this CLI option, but if it is "dependency list
>> separated by comma and space", then it should be documented. Similar to
>> `--add-modules`.
>>
>> Also, why we need `space` as well?
>>
>> For example:
>>
>> \ --linux-package-deps <package-dep-list>\n\
>> \ A comma (",") separated list of required packages or capabilities for the
>> application\n\
>>
>>
>> or if space is really needed:
>>
>> \ --linux-package-deps <package-dep-list>\n\
>> \ A comma and space (", ") separated list of required packages or
>> capabilities for the application\n\
>
> I mostly learned about this through trial and error. To me it seems it is
> just appended to the existing default dependency list, which is separated by
> space and comma. Haven’t tried omitting the space though and I am unsure
> where this is defined
I assume "dependency list separated by comma and space" is a quote from the PR
description. I understand that this is how users interpret the value of this
parameter, but for jpackage this is a pass-through option. It can be any
string. And it is documented accordingly:
Required packages or capabilities for the application
It doesn't say anything about the value format because it is irrelevant for
jpackage. Probably this is an overly vague description, and we can add details
that the value of this parameter will be passed verbatim to rpmbuild or dpkg
commands. But this is not what this PR is about.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23638#discussion_r2101102106
