On Wed, 21 May 2025 12:41:24 GMT, Stefan Lobbenmeier <d...@openjdk.org> wrote:
>> The documentation suggests that --linux-package-deps is a boolean option, >> while in fact it is a string option with dependencies separated by comma and >> space >> >> You can tell that this option is supposed to have an argument here: >> https://github.com/openjdk/jdk/blob/fea5f2b1458cdd53f437e59caaffaa6e22fb59a7/src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxPackageBundler.java#L366-L372 > > Stefan Lobbenmeier has updated the pull request incrementally with one > additional commit since the last revision: > > also use <package-dep-string> in other locations src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources.properties line 298: > 296: \ --linux-menu-group <menu-group-name>\n\ > 297: \ Menu group this application is placed in\n\ > 298: \ --linux-package-deps\n\ I am not familiar with this CLI option, but if it is "dependency list separated by comma and space", then it should be documented. Similar to `--add-modules`. Also, why we need `space` as well? For example: \ --linux-package-deps <package-dep-list>\n\ \ A comma (",") separated list of required packages or capabilities for the application\n\ or if space is really needed: \ --linux-package-deps <package-dep-list>\n\ \ A comma and space (", ") separated list of required packages or capabilities for the application\n\ ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23638#discussion_r2101024107
