On Wed, 21 May 2025 19:33:13 GMT, Alexander Matveev <almat...@openjdk.org>
wrote:
>> Stefan Lobbenmeier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> also use <package-dep-string> in other locations
>
> src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources.properties
> line 298:
>
>> 296: \ --linux-menu-group <menu-group-name>\n\
>> 297: \ Menu group this application is placed in\n\
>> 298: \ --linux-package-deps\n\
>
> I am not familiar with this CLI option, but if it is "dependency list
> separated by comma and space", then it should be documented. Similar to
> `--add-modules`.
>
> Also, why we need `space` as well?
>
> For example:
>
> \ --linux-package-deps <package-dep-list>\n\
> \ A comma (",") separated list of required packages or capabilities for the
> application\n\
>
>
> or if space is really needed:
>
> \ --linux-package-deps <package-dep-list>\n\
> \ A comma and space (", ") separated list of required packages or
> capabilities for the application\n\
I mostly learned about this through trial and error. To me it seems it is just
appended to the existing default dependency list, which is separated by space
and comma. Haven’t tried omitting the space though and I am unsure where this
is defined
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23638#discussion_r2101088895
