On Fri, 25 Oct 2024 01:49:01 GMT, Alexander Matveev <almat...@openjdk.org>
wrote:
> - It is not clear on which macOS versions codesign fails if application
> bundle contains additional content.
> - As a result test was modified to generate only application image, since PKG
> or DMG cannot be generated if signing fails. Exit code of jpackage is
> ignored, but generated application image will be checked for additional
> content.
> - This change is for macOS only.
> - Previous implementation of test (forcing expected exist code to 1) was not
> doing anything useful, since we never checked if additional content was
> copied or not.
I managed to get it working now.
1. Build a signed app image with --mac-sign
2. Add the addtional content
3. re-sign the content manually with
# Sign the final artifact
codesign --force --deep --sign "Developer ID Application: JabRef e.V.
(6792V39SK3)" \
--entitlements buildres/mac/jabref.entitlements \
--options runtime --timestamp build/distribution/JabRef.app
4. build a signed dmg/pkg
5. Notarization works now :)
-------------
PR Comment: https://git.openjdk.org/jdk/pull/21698#issuecomment-2848520498
