On Wed, 23 Apr 2025 08:54:23 GMT, Hamlin Li <m...@openjdk.org> wrote:
>> The intention is to align `_features_string` with `_features` which >> enumerates well-known CPU capabilities JVM manages. As of now, >> `_features_string` contains more information, so I introduced >> `_cpu_info_string` to keep it. >> >> Speaking of `test/lib/jdk/test/whitebox/cpuinfo/CPUInfo.java`, the approach >> chosen there may be fine for a test library, but we need a more stable API >> between JVM and JDK. > > I'm fine with this. > But it might be better to change the spliting regex of `_features_string` in > CPUFeatures.java to support riscv cpu features format. Ok, I pushed an update. Let me know what you think about it. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24462#discussion_r2057061162
