On Wed, 16 Apr 2025 21:27:32 GMT, Vladimir Ivanov <vliva...@openjdk.org> wrote:
> Both `CPUFeatures.validateFeatures` and the checks it performs are > assertions, so it has to be explicitly enabled by `-esa`. The assert > validates some assumptions the code has about the format of features string > VM produces. And feature names are controlled by JVM (JVM assigns names > itself). If there's a mismatch, something is really broken. Why do you think > it makes sense to be defensive here and try to recover if the checks fail? I was uncertain how the names were produced and if some untested hardware with additional CPU features could trigger an assert. Since as you say they are controlled by the JVM then indeed things are very broken if there is a mismatch. ------------- PR Comment: https://git.openjdk.org/jdk/pull/24462#issuecomment-2810882715
