On Wed, 16 Apr 2025 00:20:07 GMT, Paul Sandoz <psan...@openjdk.org> wrote:
>> Vladimir Ivanov has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 19 additional >> commits since the last revision: >> >> - Merge branch 'master' into vector.math.01.java >> - RVV and SVE adjustments >> - Merge branch 'master' into vector.math.01.java >> - Fix windows-aarch64 build failure >> - features_string -> cpu_info_string >> - Reviews and Float64Vector-related fix >> - Misc fixes and cleanups >> - CPU features support >> - Cleanup >> - TODO list >> - ... and 9 more: https://git.openjdk.org/jdk/compare/f025c30a...0ffed12f > > src/hotspot/share/opto/vectorIntrinsics.cpp line 488: > >> 486: // V binaryOp(long address, Class<? extends V> vClass, Class<E> >> elementType, int length, >> 487: // V v1, V v2, >> 488: // BinaryOperation<V, ?> defaultImpl) > > `debugName` parameter is missing It seems the function should be updated to `libraryBinaryOp` and `libraryUnaryOp`? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24462#discussion_r2045846887
