On Mon, 7 Apr 2025 17:44:33 GMT, Chen Liang <[email protected]> wrote:
>> Vladimir Ivanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> features_string -> cpu_info_string
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/CPUFeatures.java
> line 44:
>
>> 42: String featuresString = VectorSupport.getCPUFeatures();
>> 43: debug(featuresString);
>> 44: String[] features = featuresString.toLowerCase().split(", "); //
>> ", " is used as a delimiter
>
> Please use `toLowerCase(Locale.ROOT)`: if the system locale is turkish, `I`
> and dotless i are two letters, and the dotless i will fail in the subsequent
> `validateFeatures` assertion. Same for `hasFeature`.
Good point. Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24462#discussion_r2032135321
