On Wed, 26 Mar 2025 19:19:03 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reflects the review comment > > src/java.base/windows/native/libjava/java_props_md.c line 131: > >> 129: } >> 130: >> 131: static char* getConsoleEncoding(boolean output) > > I assume it would be BOOL but I see several other functions here are using > boolean with TRUE/FALSE so it should be okay. Oh that's right. Changed boolean to BOOL. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24263#discussion_r2014989810
