On Wed, 26 Mar 2025 18:57:37 GMT, Naoto Sato <na...@openjdk.org> wrote:

> Those system property values on Windows were derived from Windows' 
> `GetConsoleCP()` call, but they should have been taken from 
> `GetConsoleOutputCP()`. Replacing the incorrect call with the correct one 
> won't change any behavior, as both calls return the same value by default 
> (`GetOEMCP()`). However, it is still the right thing to do.

Looks reasonable to me.

-------------

Marked as reviewed by bpb (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24263#pullrequestreview-2718359173

Reply via email to