On Wed, 26 Mar 2025 18:57:37 GMT, Naoto Sato <na...@openjdk.org> wrote:
> Those system property values on Windows were derived from Windows' > `GetConsoleCP()` call, but they should have been taken from > `GetConsoleOutputCP()`. Replacing the incorrect call with the correct one > won't change any behavior, as both calls return the same value by default > (`GetOEMCP()`). However, it is still the right thing to do. src/java.base/windows/native/libjava/java_props_md.c line 131: > 129: } > 130: > 131: static char* getConsoleEncoding(boolean output) I assume it would be BOOL but I see several other functions here are using boolean with TRUE/FALSE so it should be okay. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24263#discussion_r2014854280
