On Fri, 17 Jan 2025 23:10:54 GMT, Justin Lu <j...@openjdk.org> wrote:
>> Please review this PR and CSR which adds a method to _java.util.Currency_
>> which returns a stream of the available Currencies.
>>
>> The motivation can be found in the CSR.
>
> Justin Lu has updated the pull request incrementally with one additional
> commit since the last revision:
>
> reflect Roger's review
test/jdk/java/util/Currency/AvailableCurrenciesTest.java line 44:
> 42: public void streamEqualsSetTest() {
> 43: var currencies = Currency.getAvailableCurrencies();
> 44: assertEquals(currencies,
> Currency.availableCurrencies().collect(Collectors.toSet()));
Generally, a message describing the failure is more useful than just a
stacktrace. (the 3rd arg on assertEquals override.)
It avoids needing to find the source code to create the bug report.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23165#discussion_r1920868545
