On Fri, 17 Jan 2025 22:49:07 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> init hashset w/ accurate size via HashSet.newHashSet(int) > > src/java.base/share/classes/java/util/Currency.java line 439: > >> 437: * contains all the available currencies, which may include >> currencies >> 438: * that represent obsolete ISO 4217 codes. If there is no currency >> available >> 439: * in the runtime, the returned set is empty. The set can be >> modified > > An apiNote might be appropriate to refer/recommend using the new > `availableCurrencies()` API. > And/or an @see link to the method. Thanks Roger, incorporated both your suggestions in https://github.com/openjdk/jdk/pull/23165/commits/dcb4a9bfea1002044483aea483af8e6107eb525d. Note, I intentionally did not add any wording regarding the defensive copy in the `apiNote`, considering that is an implementation specific caveat. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23165#discussion_r1920856865
