On Mon, 20 Jan 2025 09:46:05 GMT, Viktor Klang <vkl...@openjdk.org> wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> provide message for test assertion
>
> src/java.base/share/classes/java/util/Currency.java line 494:
>
>> 492:
>> 493: if (scEntry.cutOverTime == Long.MAX_VALUE
>> 494: || System.currentTimeMillis() <
>> scEntry.cutOverTime) {
>
> It'd be better to obtain the current time once and compare against the same
> value for all entries rather than potentially using different current times
> for each comparison.
That's a good point. I filed
[JDK-8348205](https://bugs.openjdk.org/browse/JDK-8348205) because that change
would have its own behavioral concerns, which I don't want to overlap with this
issue/CSR.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23165#discussion_r1924212238
