On Fri, 17 Jan 2025 22:37:35 GMT, Damon Nguyen <dngu...@openjdk.org> wrote:
>> Please review this PR which contains the l10n translations for between RDP1
>> and RDP2 for the JDK24 stabilization branch.
>>
>> Note that these translations are only associated with changes made to the
>> stabilization branch. This PR will not include any translations for changes
>> since RDP1, that were not back-ported to the stabilization branch. Also note
>> that while most changes here are associated with an English change, there
>> were some standalone translation improvements.
>>
>> Once this pull request is integrated, it will be back-ported to the jdk24
>> branch.
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/resources/jlink_de.properties
> line 80:
>
>> 78: err.no.module.path=--module-path-Option muss mit --add-modules
>> ALL-MODULE-PATH angegeben werden
>> 79: err.empty.module.path=Kein Modul im Modulpfad "{0}" mit --add-modules
>> ALL-MODULE-PATH gefunden
>> 80: err.limit.modules=--limit-modules nicht mit --add-modules
>> ALL-MODULE-PATH zulässig
>
> I see German has more being changed when compared to Japanese & Chinese. Are
> these updated translations for German specifically? I see no related change
> for the other 2 languages for say `err.runtime.link.not.linkable.runtime`.
Yes, see the other comment.
> src/jdk.jlink/share/classes/jdk/tools/jmod/resources/jmod_de.properties line
> 60:
>
>> 58: main.opt.target-platform.arg=target-platform
>> 59: main.opt.module-path=Modulpfad
>> 60: main.opt.hash-modules=Berechnet und erfasst Hashes zur Bindung eines
>> verpackten Moduls an Module, die dem angegebenen <Regex-Muster> entsprechen
>> und direkt oder indirekt davon abhängen. Die Hashes werden in der erstellten
>> JMOD-Datei oder in einer JMOD- oder modularen JAR-Datei in dem Modulpfad
>> erfasst, der im jmod-Hashbefehl angegeben ist.
>
> I assume this is more evidence that the German differences are just updated
> translations for German?
Yes, there were standalone German translation updates. Some were also reverts
to fixes we made last time for German translations specifically, as they were
rejected by the translation team. In any case, I think it is probably best not
to deviate from their translations unless they are incorrect.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23184#discussion_r1920839939
PR Review Comment: https://git.openjdk.org/jdk/pull/23184#discussion_r1920839823
