On Thu, 19 Dec 2024 16:59:21 GMT, Mandy Chung <mch...@openjdk.org> wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Don't allow --limit-modules with ALL-MODULE-PATH
>
> test/jdk/tools/jlink/basic/AllModulePath.java line 133:
>
>> 131: */
>> 132: @Test
>> 133: public void testSubsetModules() throws Throwable {
>
> Can simply move `testLimitModules` (line 209-229) to replace this method.
> This test case is not needed as this test focuses on `ALL-MODULE-PATH` and
> covered by other tests. Modifying `testLimitModules` to test the error
> will help as clearly shown from the commit.
Sure.
> test/jdk/tools/jlink/basic/AllModulePath.java line 162:
>
>> 160: List<String> opts = List.of("--module-path", MODS.toString(),
>> 161: "--output", image.toString(),
>> 162: "--add-modules", "m1,test",
>
> Suggestion:
>
> "--add-modules", "m1",
>
>
> This can show clearly that `ALL-MODULE-PATH` includes all modules on the
> module path.
OK.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22494#discussion_r1893156083
PR Review Comment: https://git.openjdk.org/jdk/pull/22494#discussion_r1893155667
