On Mon, 2 Dec 2024 18:25:22 GMT, Severin Gehwolf <sgehw...@openjdk.org> wrote:
> Please review this extension to #22609 which now disallows `ALL-MODULE-PATH` > without explicit `--module-path` option or a non-existent module path. In > addition, this fixes a bug mentioned in #22609 when `ALL-MODULE-PATH` and > `--limit-modules` are used in combination. It failed earlier and passes now > due to alignment of `ModuleFinder`s. With this patch JEP 493 enabled builds > and regular JDK builds behave the same in terms of `ALL-MODULE-PATH`. > > When an explicit module path is being added, there is no difference. All > modules on that path will be added as roots. Tests have been added for the > various cases and existing tests updated to allow for them to run on JEP 493 > enabled builds. Thoughts? > > Testing: > - [x] GHA, `test/jdk/tools/jlink` (all pass) > - [x] Added jlink test. This pull request has now been integrated. Changeset: bcb1bdaa Author: Severin Gehwolf <sgehw...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/bcb1bdaae772c752d54939dae3a0d95892acc228 Stats: 258 lines in 6 files changed: 151 ins; 44 del; 63 mod 8345259: Disallow ALL-MODULE-PATH without explicit --module-path Reviewed-by: mchung ------------- PR: https://git.openjdk.org/jdk/pull/22494
